PHP 8 match() expression is not counted in Generic.Metrics.CyclomaticComplexity #3472
Milestone
Comments
MarkBaker
pushed a commit
to MarkBaker/PHP_CodeSniffer
that referenced
this issue
Nov 12, 2021
Calculate CYC for PHP 8 match() expression in Cyclomatic Complexity sniff
MarkBaker
changed the title
MarkBaker
pushed a commit
to MarkBaker/PHP_CodeSniffer
that referenced
this issue
Dec 3, 2021
This is for Issue squizlabs#3472, which identified that match() was not being included in the count, when it should have been (similar to a switch statement). There is no need to add one for the T_MATCH_DEFAULT token, because this is always followed by a T_MATCH_ARROW token, and to do so would be to double-count that entry. Unit tests provided.
gsherwood
changed the title
gsherwood
pushed a commit
that referenced
this issue
Dec 6, 2021
This is for Issue #3472, which identified that match() was not being included in the count, when it should have been (similar to a switch statement). There is no need to add one for the T_MATCH_DEFAULT token, because this is always followed by a T_MATCH_ARROW token, and to do so would be to double-count that entry. Unit tests provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PHP8 Introduced
match()as a new expression syntax, similar to aswitchstatement but with a rather different structure, using an arrow (=>) to separate thecasefrom the expression that it would return. This should also be factored into the CYC calculation for theGeneric.Metrics.CyclomaticComplexitysniff.When calculating the CYC, this should be evaluated like a
switchstatement, with eachT_MATCH_ARROWtoken corresponding to acaseand increasing the CYC by one. There is no need to add one for theT_MATCH_DEFAULTtoken, because this is followed by aT_MATCH_ARROWtoken, and to do so would be to double-count that entry.PR to follow.
The text was updated successfully, but these errors were encountered: