Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive: 4.1.2: Wrapping label not seen if input is nested in a span #209

Closed
michaelcpuckett opened this issue Feb 8, 2018 · 0 comments
Closed

False positive: 4.1.2: Wrapping label not seen if input is nested in a span #209

michaelcpuckett opened this issue Feb 8, 2018 · 0 comments
Assignees
@ironikart
Labels
Bug

Comments

@michaelcpuckett
Copy link 

<label>
  <span>
    <input type="radio" name="foo" value="foo" />
  </span>
  <span>
    Lorem ipsum
  </span>
</label>

The accessibility tree will recognize this label even though the input is nested in a span.

I don't think this should be a violation.
@ironikart ironikart added the Bug label Feb 8, 2018
@ironikart ironikart self-assigned this Feb 8, 2018
dochne pushed a commit to silktide/HTML_CodeSniffer that referenced this issue Mar 8, 2021
@ironikart
Changed wrapping input label to detect any parent <label> rather than…
672777d 
… just a direct parent. This is not detecting for a valid phrasing content node (i.e. a div is not a valid child of a label), which is not in the scope of wcag testing. This resolves squizlabs#209.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ironikart ironikart

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ironikart @michaelcpuckett