Corrected feed-in and consumed energy source and type for x3-hybrid-g4 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H3-Hybrid-G4: both feed-in and consumed energy values for `Total` and `DailyTotal` were swapped. Both of the above were marked as `Total`. - Switched daily and total with each other - Marked reset daily as `DailyTotal`
X3 Hybrid G4 inverter: corrected expected values for consumed energy daily and total as daily was bigger than total - total as aggregate should in general be higher.
Breaking change: - added 'today' postfix to daily feed-in and consumed energy to adhere to the convention used for other sensors. Attempted to correct failing coverage.
|
Hi @squishykid , I finally found a while and had a weekend off so I attempted to fix switched values for some sensors. Would you find a moment to take a look at this PR? It should fix this issue in HA: home-assistant/core#130742 |
|
Looks good to me mate! Luckily I also have a weekend off for the first time in a long time 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H3-Hybrid-G4: both feed-in and consumed energy values for
TotalandDailyTotalwere swapped. Both of the above were marked asTotal. Daily reset feed-in and consumed energy lack thetodaypostfix used but other sensors.DailyTotaltodaypostfix to daily reset feed-in and consumed energy to adhere to the convention.Fixes: home-assistant/core#130742