-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for instant loading with keyboard navigation #5743
Conversation
Sorry to go on a trajectory a bit, but this is very interesting. For our use case, the custom |
@vedranmiletic the instant loading code got a refactor and I took the chance to very thoroughly document how it's done and what the limitations are. Take a look at the source code. If questions remain, please ask them here. We could probably implement a traversal and updating of tags so tags are entirely added and replaced, not only updated. |
This is the list of tags that get updated on instant loading, right? I think it would be useful to let users extend this list easily (probably in the config file), so if we use overrides/templates to add custom tags, those would be handles as well. Support for adding and removing tags would also be useful when custom tags are added only to specific pages. |
Thanks for the suggestion. It's a better idea to deduplicate and update all tags, so there's no configuration necessary, which is exactly what we will do. This will also mean that custom tags are correctly added/removed/replaced. |
@vedranmiletic this PR implements auto-replacement of tags – this should also solve the problem you described |
@squidfunk that's great, eagerly waiting for the next release! |
Looks like it's going to be released tomorrow. |
Released as part of 9.4.2. |
This PR improves instant loading for keyboard navigation. We need to refactor instant loading a bit to support adding and removal of elements in the
head
when they're not present. This needs to be addressed before merging this PR.