Fixe time being dropped from blog post dates

squidfunk · Dec 7, 2023 · 5b70a0c · 5b70a0c
1 parent 63de1a0
commit 5b70a0c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/material/plugins/blog/structure/options.py b/material/plugins/blog/structure/options.py
@@ -62,6 +62,14 @@ def pre_validation(self, config: Config, key_name: str):
 
         # Convert all date values to datetime
         for key, value in config[key_name].items():
+
+            # Handle datetime - since datetime is a subclass of date, we need
+            # to check it first, or we'll loose time - see https://t.ly/-KG9N
+            if isinstance(value, datetime):
+                continue
+
+            # Handle date - we set 00:00:00 as the default time, if the author
+            # only supplied a date, and convert it to datetime
             if isinstance(value, date):
                 config[key_name][key] = datetime.combine(value, time())
 

diff --git a/src/plugins/blog/structure/options.py b/src/plugins/blog/structure/options.py
@@ -62,6 +62,14 @@ def pre_validation(self, config: Config, key_name: str):
 
         # Convert all date values to datetime
         for key, value in config[key_name].items():
+
+            # Handle datetime - since datetime is a subclass of date, we need
+            # to check it first, or we'll loose time - see https://t.ly/-KG9N
+            if isinstance(value, datetime):
+                continue
+
+            # Handle date - we set 00:00:00 as the default time, if the author
+            # only supplied a date, and convert it to datetime
             if isinstance(value, date):
                 config[key_name][key] = datetime.combine(value, time())