Fix CachePeer.cc:101 "!tcp_up" assertion after cache_peer death #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getFirstUpParent() could return a non-nil cache_peer even if the search failed. Broken since commit 2e24d0b.
Also removed an unwanted empty line.
rousskov
approved these changes
Dec 13, 2024
rousskov
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Dec 15, 2024
getFirstUpParent() could return a down (or otherwise disqualified) cache_peer. Broken by 2023 commit 2e24d0b. Refactored function structure to improve code quality, partially addressing "use our return/reporting style" TODO in getDefaultParent().
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
rousskov
removed
the
S-could-use-an-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getFirstUpParent() could return a down (or otherwise disqualified)
cache_peer. Broken by 2023 commit 2e24d0b.
Refactored function structure to improve code quality, partially
addressing "use our return/reporting style" TODO in getDefaultParent().