-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Remove change-minimizing MemObject::Io hack #1957
Maintenance: Remove change-minimizing MemObject::Io hack #1957
Conversation
I have adjusted PR title to be more specific and use I also adjusted PR description to supply useful information instead of narrating arguably self-documenting diff. |
…specifiers, instead using enum values directly from Store class
…specifiers, instead using enum values directly from Store class
@rousskov I have made the changes in all the files that were using Please review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for completing this TODO!
P.S. Just FYI: You do not have to use formal prefixes like Maintenance:
in individual branch commit titles, especially branch commits other than the first one1. There is nothing wrong with using them there either, but my earlier comment about prefixes only applied to PR title (that becomes official commit message title when PR is auto-merged by Anubis).
Footnotes
-
Various PR creation tools like
gh
treat "single-commit PR branches" specially, automatically using that single commit message to compute PR title/description. ↩
Added in 2018 commit 4310f8b.
Added in 2018 commit 4310f8b.