Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor peerRefreshDNS() to clarify its (void*)1 logic #1950

Closed
wants to merge 5 commits into from
Closed

Refactor peerRefreshDNS() to clarify its (void*)1 logic #1950

wants to merge 5 commits into from

Conversation

eduard-bagdasaryan
Copy link
Contributor

Creating a raw pointer with 1 as an address/value raised red flags, and
it was difficult to interpret tricky peerRefreshDNS() logic correctly.

@yadij yadij added S-waiting-for-more-reviewers needs a reviewer and/or a second opinion backport-to-v6 maintainer has approved these changes for v6 backporting labels Nov 20, 2024
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-more-reviewers needs a reviewer and/or a second opinion labels Nov 20, 2024
squid-anubis pushed a commit that referenced this pull request Nov 20, 2024
@eduard-bagdasaryan @squid-anubis
Refactor peerRefreshDNS() to clarify its (void*)1 logic (#1950)
dd3292c 
Creating a raw pointer with 1 as an address/value raised red flags, and
it was difficult to interpret tricky peerRefreshDNS() logic correctly.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 20, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Nov 20, 2024
kinkie pushed a commit to kinkie/squid that referenced this pull request Jan 20, 2025
@eduard-bagdasaryan @kinkie
Refactor peerRefreshDNS() to clarify its (void*)1 logic (squid-cache#…
05139d2 
…1950)

Creating a raw pointer with 1 as an address/value raised red flags, and
it was difficult to interpret tricky peerRefreshDNS() logic correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadij yadij yadij approved these changes

@kinkie kinkie kinkie approved these changes

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
backport-to-v6 maintainer has approved these changes for v6 backporting M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eduard-bagdasaryan @rousskov @kinkie @yadij @squid-anubis