CI: Use ccache-action repo maintained by its original author #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squid-cache/[email protected] is not allowed to be used in ... For recent commit 627cca6, we cloned hendrikmuhs/ccache-action repository because GitHub Actions prohibited usage of that repository in Squid Project CI tests. Cloning worked around that restriction, but we did not realize that there are other solutions, and that cloning forces all other Squid repositories to either clone squid-cache/ccache-action or permit squid-cache/ccache-action execution by other means. To reduce the number of obscure repositories Squid Project and others have to deal with, it is better to adjust repository configuration to allow well-known hendrikmuhs/ccache-action in "Actions permissions" at https://github.com/.../squid/settings/actions
yadij
approved these changes
Nov 11, 2024
yadij
added
the
M-cleared-for-merge
rousskov
commented
Nov 11, 2024
| @@ -133,7 +133,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Setup ccache | |||
| uses: squid-cache/[email protected] | |||
| uses: hendrikmuhs/[email protected] | |||
There was a problem hiding this comment.
Using official ccache-action repository now works because I have adjusted Squid Project GitHub Actions configuration to allow that action reuse.
rousskov
added
the
S-could-use-an-approval
|
Oh fantastic! I could not find any documentation about this authorization or I would have used it in the first place. |
kinkie
approved these changes
Nov 11, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Nov 11, 2024
squid-cache/[email protected] is not allowed to be used in ... For recent commit 627cca6, we cloned hendrikmuhs/ccache-action repository because GitHub Actions prohibited usage of that repository in Squid Project CI tests. Cloning worked around that restriction, but we did not realize that there are other solutions, and that cloning forces all other Squid repositories to either clone squid-cache/ccache-action or permit squid-cache/ccache-action execution by other means. To reduce the number of obscure repositories Squid Project and others have to deal with, it is better to adjust repository configuration to allow well-known hendrikmuhs/ccache-action in "Actions permissions" at https://github.com/.../squid/settings/actions
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
rousskov
removed
the
S-could-use-an-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For recent commit 627cca6, we cloned hendrikmuhs/ccache-action
repository because GitHub Actions prohibited usage of that repository in
Squid Project CI tests. Cloning worked around that restriction, but we
did not realize that there are other solutions, and that cloning forces
all other Squid repositories to either clone squid-cache/ccache-action
or permit squid-cache/ccache-action execution by other means.
To reduce the number of obscure repositories Squid Project and others
have to deal with, it is better to adjust repository configuration to
allow well-known hendrikmuhs/ccache-action in "Actions permissions" at
https://github.com/.../squid/settings/actions