Ftp::Gateway may segfault in level-3 double-complete debugs() #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ftp::Gateway::completeForwarding() must check that both Control and Data connections are still available before dereferencing them.
rousskov
changed the title
rousskov
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thank you for fixing this bug! I have adjusted PR title and description to highlight that this bug is specific to level-3 debugging, may not be triggered in every double-complete case, and that the ugly solution mimics existing Ftp::Relay::abortOnData() code. Please adjust further as needed.
Long-term, we should do better, but this minimal fix is enough for now.
rousskov
added
M-cleared-for-merge
yadij
approved these changes
Oct 28, 2024
yadij
removed
the
S-could-use-an-approval
rousskov
added
the
S-could-use-an-approval
|
@yadij, |
kinkie
approved these changes
Oct 29, 2024
kinkie
removed
the
S-could-use-an-approval
squid-anubis
pushed a commit
that referenced
this pull request
Oct 29, 2024
Ftp::Gateway::completeForwarding() must check data.conn pointer before dereferencing it. Long-term, we should improve Comm::ConnectionPointer printing to safely report Connection::id (where available). This minimal fix just mimics existing Ftp::Relay::abortOnData() solution.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ftp::Gateway::completeForwarding() must check data.conn pointer before
dereferencing it. Long-term, we should improve Comm::ConnectionPointer
printing to safely report Connection::id (where available). This minimal
fix just mimics existing Ftp::Relay::abortOnData() solution.