Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compilation on Gentoo #1920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix cross-compilation on Gentoo #1920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ AS_IF([test "x$ac_cv_path_PERL" = "xnone"],[
AC_PATH_PROG(POD2MAN, pod2man, $FALSE)
AM_CONDITIONAL(ENABLE_POD2MAN_DOC, test "x${ac_cv_path_POD2MAN}" != "x$FALSE")

AC_PATH_PROG(AR, ar, $FALSE)
AC_CHECK_TOOL(AR, ar, :)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The /bin/false alternative is there intentionally to halt early "on first use". Using : will silently skip problems until a lot more build cycles have been wasted.

Suggested change
AC_CHECK_TOOL(AR, ar, :)
AC_CHECK_TOOL(AR, ar, $FALSE)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thesamesam, if you commit Amos suggestion, please do not forget to adjust PR description that currently claims that we are emulating AC_PROG_AR in this fix. AC_PROG_AR does not use $FALSE. It uses : or, effectively, "true" AFAICT:

AC_DEFUN([AC_PROG_AR],
[AC_CHECK_TOOL(AR, ar, :)])

AR_R="$AR r"
AC_SUBST(AR_R)

Expand Down
Loading