-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Remove unused fde::flags.close_on_exec #1879
Closed
rousskov
wants to merge
2
commits into
squid-cache:master
from
measurement-factory:SQUID-111-unused-flags-close_on_exec
Closed
Maintenance: Remove unused fde::flags.close_on_exec #1879
rousskov
wants to merge
2
commits into
squid-cache:master
from
measurement-factory:SQUID-111-unused-flags-close_on_exec
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadij
approved these changes
Aug 3, 2024
yadij
added
M-cleared-for-merge
https://github.com/measurement-factory/anubis#pull-request-labels
S-could-use-an-approval
An approval may speed this PR merger (but is not required)
labels
Aug 3, 2024
kinkie
approved these changes
Aug 3, 2024
kinkie
added
the
backport-to-v6
maintainer has approved these changes for v6 backporting
label
Aug 4, 2024
rousskov
removed
the
S-could-use-an-approval
An approval may speed this PR merger (but is not required)
label
Aug 5, 2024
squid-anubis
pushed a commit
that referenced
this pull request
Aug 7, 2024
squid-anubis
added
the
M-waiting-staging-checks
https://github.com/measurement-factory/anubis#pull-request-labels
label
Aug 7, 2024
squid-anubis
added
M-merged
https://github.com/measurement-factory/anubis#pull-request-labels
and removed
M-waiting-staging-checks
https://github.com/measurement-factory/anubis#pull-request-labels
M-cleared-for-merge
https://github.com/measurement-factory/anubis#pull-request-labels
labels
Aug 7, 2024
squidadm
removed
the
backport-to-v6
maintainer has approved these changes for v6 backporting
label
Aug 8, 2024
queued for backport to v6 |
yadij
pushed a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.