Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove unused fde::flags.close_on_exec #1879

Conversation

rousskov
Copy link
Contributor

@rousskov rousskov commented Aug 2, 2024

This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.

This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Aug 3, 2024
@kinkie kinkie added the backport-to-v6 maintainer has approved these changes for v6 backporting label Aug 4, 2024
@rousskov rousskov removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Aug 5, 2024
squid-anubis pushed a commit that referenced this pull request Aug 7, 2024
This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Aug 7, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 7, 2024
squidadm pushed a commit to squidadm/squid that referenced this pull request Aug 7, 2024
This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.
@squidadm squidadm removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Aug 8, 2024
@squidadm
Copy link
Collaborator

squidadm commented Aug 8, 2024

queued for backport to v6

yadij pushed a commit that referenced this pull request Aug 8, 2024
This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.
kinkie pushed a commit to kinkie/squid that referenced this pull request Oct 12, 2024
This flag became effectively unused in 2010 commit cfd6652 when
copyFDFlags() -- the only function checking the flag -- became unused.
That unused function was removed a bit later in commit 5ae21d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants