-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduced build warnings [-Wmissing-declarations] #1876
Reduced build warnings [-Wmissing-declarations] #1876
Conversation
This change fixes a few manually picked cases in sources that are not normally compiled on our CI nodes. There are probably more missing declarations, but we do not know how to find them automatically. Also removed a few seemingly unused functions and declarations.
This is a draft PR because I cannot test these changes. This PR probably should not be merged without testing in environment(s) where the modified files are compiled. The changes themselves were prompted by a "Can't build squid on Windows" email sent to Project info alias:
|
FTR; A cross-build of these helpers with MinGW64 confirms this PR to fix the errors mentioned by @rousskov. There are still many others to fix in them, but this is at least some progress. |
This change fixes a few manually picked cases in sources that are not normally compiled on our CI nodes. There are probably more missing declarations, but we do not know how to find them automatically. Also removed a few seemingly unused functions and declarations.
This change fixes a few manually picked cases in sources that are not normally compiled on our CI nodes. There are probably more missing declarations, but we do not know how to find them automatically. Also removed a few seemingly unused functions and declarations.
queued for backport to v6 |
This change fixes a few manually picked cases in sources that are not normally compiled on our CI nodes. There are probably more missing declarations, but we do not know how to find them automatically. Also removed a few seemingly unused functions and declarations.
This change fixes a few manually picked cases in sources that are not normally compiled on our CI nodes. There are probably more missing declarations, but we do not know how to find them automatically. Also removed a few seemingly unused functions and declarations.
This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.
Also removed a few seemingly unused functions and declarations.