Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced build warnings [-Wmissing-declarations] #1876

Conversation

rousskov
Copy link
Contributor

@rousskov rousskov commented Aug 1, 2024

This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.

This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.
@rousskov
Copy link
Contributor Author

rousskov commented Aug 1, 2024

This is a draft PR because I cannot test these changes. This PR probably should not be merged without testing in environment(s) where the modified files are compiled.

The changes themselves were prompted by a "Can't build squid on Windows" email sent to Project info alias:

This is the version I have: "squid-6.9-20240523-rfb0d1814dd.tar.gz". 

I set up Cygwin environment on Windows and followed the instructions. Midway through the `make` command, I get errors, starting with the ones mentioned below: 

ext_lm_group_acl.cc:109:1: error: no previous declaration for ‘char* AllocStrFromLSAStr(LSA_UNICODE_STRING)’ [-Werror=missing-declarations]
  109 | AllocStrFromLSAStr(LSA_UNICODE_STRING LsaStr)
      | ^~~~~~~~~~~~~~~~~~
ext_lm_group_acl.cc:131:1: error: no previous declaration for ‘char* GetDomainName()’ [-Werror=missing-declarations]
  131 | GetDomainName(void)
      | ^~~~~~~~~~~~~
In file included from ../../../../compat/compat.h:104,
                 from ../../../../include/squid.h:32,
                 from ext_lm_group_acl.cc:78:

@rousskov rousskov added the S-waiting-for-more-reviewers needs a reviewer and/or a second opinion label Aug 1, 2024
@yadij
Copy link
Contributor

yadij commented Aug 11, 2024

FTR; A cross-build of these helpers with MinGW64 confirms this PR to fix the errors mentioned by @rousskov. There are still many others to fix in them, but this is at least some progress.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels backport-to-v6 maintainer has approved these changes for v6 backporting and removed S-waiting-for-more-reviewers needs a reviewer and/or a second opinion labels Aug 12, 2024
@yadij yadij marked this pull request as ready for review August 12, 2024 06:16
squid-anubis pushed a commit that referenced this pull request Aug 12, 2024
This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 12, 2024
@rousskov rousskov removed the M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Aug 12, 2024
@squid-anubis squid-anubis added M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 12, 2024
@rousskov rousskov removed the M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Aug 12, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Aug 12, 2024
squidadm pushed a commit to squidadm/squid that referenced this pull request Aug 12, 2024
This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.
@squidadm squidadm removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Aug 13, 2024
@squidadm
Copy link
Collaborator

queued for backport to v6

yadij pushed a commit that referenced this pull request Aug 13, 2024
This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.
kinkie pushed a commit to kinkie/squid that referenced this pull request Oct 12, 2024
This change fixes a few manually picked cases in sources that are not
normally compiled on our CI nodes. There are probably more missing
declarations, but we do not know how to find them automatically.

Also removed a few seemingly unused functions and declarations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants