Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ACLFilledChecklist::request to smart Pointer #1501

Closed
wants to merge 2 commits into from
Closed

Upgrade ACLFilledChecklist::request to smart Pointer #1501

wants to merge 2 commits into from

Conversation

yadij
Copy link
Contributor

@yadij yadij commented Oct 7, 2023 •
edited
Loading

No logic changes. Just the member type.

@rousskov rousskov self-requested a review October 7, 2023 15:07
rousskov
rousskov requested changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix PR title -- this PR does not change AccessLogEntry::request. The rest is minor polishing.

src/external_acl.cc Outdated Show resolved Hide resolved
src/acl/FilledChecklist.h Outdated Show resolved Hide resolved
@yadij yadij changed the title Upgrade AccessLogEntry::request to smart Pointer Upgrade ACLFilledChecklist::request to smart Pointer Oct 8, 2023
@yadij yadij requested a review from rousskov October 8, 2023 20:23
@rousskov rousskov added the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Oct 9, 2023
squid-anubis pushed a commit that referenced this pull request Oct 9, 2023
@yadij @squid-anubis
Upgrade ACLFilledChecklist::request to smart Pointer (#1501)
f05e4f3 
No logic changes. Just the member type.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Oct 9, 2023
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Oct 9, 2023
@yadij yadij deleted the v7-acl-pointers-1 branch October 13, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yadij @rousskov @squid-anubis