Do not use raw pointers to index userhash CachePeers #1496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7959b5 has a similar fix for CARP cache peers.
Simplified and improved code safety by using CbcPointers for userhash cache_peers, as we have done for CARP peers in recent commit e7959b5. Also fixed mgr:userehash Cache Manager reports to detail relevant cache_peers instead of all cache_peers. This problem existed since inception (2008 commit f7e1d9c) as detailed in recent commit e7959b5.
|
Similar sourcehash changes are already in master 2d5ac43. |
rousskov
added
the
M-cleared-for-merge
yadij
approved these changes
Sep 27, 2023
squid-anubis
pushed a commit
that referenced
this pull request
Sep 28, 2023
Simplified and improved code safety by using CbcPointers for userhash cache_peers, as we have done for CARP peers in recent commit e7959b5. Also fixed mgr:userehash Cache Manager reports to detail relevant cache_peers instead of all cache_peers. This problem existed since inception (2008 commit f7e1d9c) as detailed in recent commit e7959b5.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified and improved code safety by using CbcPointers for userhash
cache_peers, as we have done for CARP peers in recent commit e7959b5.
Also fixed mgr:userehash Cache Manager reports to detail relevant
cache_peers instead of all cache_peers. This problem existed since
inception (2008 commit f7e1d9c) as detailed in recent commit e7959b5.