Fix build on GNU/Hurd #1417
Closed
Fix build on GNU/Hurd #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Definitions of htonl() and htons() require these headers, in this order.
yadij
added
the
backport-to-v6
kinkie
approved these changes
Jul 12, 2023
yadij
added
the
M-cleared-for-merge
rousskov
approved these changes
Jul 12, 2023
| #if HAVE_ARPA_INET_H | ||
| #include <arpa/inet.h> | ||
| #endif | ||
|
|
||
| static_assert(sizeof(RandomUuid) == 128/8, "RandomUuid has RFC 4122-prescribed 128-bit size"); |
There was a problem hiding this comment.
Definitions of htonl() and htons() require these headers, in this order.
A better fix would provide a Squid-specific header that can be included to get htonl() and similar declarations (and an automated check for that header inclusion) instead of chasing #include violations one build failure at a time while we continue to copy-paste htonl() callers.
FWIW, here are some of the other source files that make htonl() or similar calls but do not explicitly include the two system headers added in this PR. Some of the entries on this list include one header and most get the right declarations indirectly (in most build environments), from places like sys/socket.h.
- lib/rfcnb/rfcnb-util.c: missing netinet/in.h
- src/CacheDigest.cc: missing both
- src/adaptation/icap/ServiceRep.cc: missing both
- src/auth/basic/RADIUS/Changelog: missing both
- src/auth/basic/RADIUS/basic_radius_auth.cc: missing arpa/inet.h
- src/auth/basic/RADIUS/radius-util.cc: missing arpa/inet.h
src/base/RandomUuid.cc: missing both- src/cache_cf.cc: missing both
- src/delay_pools.cc: missing both
- src/dns/rfc3596.cc: missing arpa/inet.h
- src/dns_internal.cc: missing both
- src/htcp.cc: missing both
- src/icmp/Icmp.cc: missing both
- src/icmp/net_db.cc: missing both
- src/icp_v2.cc: missing both
- src/ip/Address.cc: missing netinet/in.h
- src/ip/Intercept.cc: missing arpa/inet.h
- src/ip/QosConfig.cc: missing both
- src/neighbors.cc: missing both
- src/peer_digest.cc: missing both
- src/store_digest.cc: missing both
- src/tests/testIcmp.cc: missing both
- src/wccp.cc: missing both
- src/wccp2.cc: missing both
Disclaimer: Manually, I have only checked a few entries on the above list.
squid-anubis
pushed a commit
that referenced
this pull request
Jul 12, 2023
Definitions of htonl() and htons() require these headers, in this order.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jul 25, 2023
Definitions of htonl() and htons() require these headers, in this order.
squidadm
removed
the
backport-to-v6
|
queued for backport to v6 |
yadij
added a commit
that referenced
this pull request
Jul 25, 2023
Definitions of htonl() and htons() require these headers, in this order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions of htonl() and htons() require these headers, in this order.