Preserve caller context in TcpAcceptor #1087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, acceptOne() was losing FTP DATA TcpAcceptor context by unconditionally resetting the context to a nil listenPort_. Also, TcpAcceptor methods should not (be expected to) explicitly set their job code context. Instead, the job should be created in the right code context, allowing job-created async calls to auto-manage code context. The updated port-iterating clientHttpConnectionsOpen() and Ftp::StartListening() loops now set the right code context when creating async calls that result in TcpAcceptor job creation.
yadij
approved these changes
Jul 14, 2022
rousskov
approved these changes
Jul 14, 2022
| for (AnyP::PortCfgPointer s = HttpPortList; s != nullptr; s = s->next) { | ||
| CodeContext::Reset(s); | ||
| if (s->listenConn != nullptr) { | ||
| debugs(1, Important(14), "Closing HTTP(S) port " << s->listenConn->local); |
There was a problem hiding this comment.
This and similar debugs() will now report the port twice, but we are already polishing how the listening ports are reported (including these messages) in #835, so I think it is best to merge this (much simpler) PR first and address the double-reporting concern in #835, where we have much better tools to do so. That is why I am approving this PR despite this (hopefully very temporary) flaw.
rousskov
added
the
M-cleared-for-merge
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Jul 15, 2022
Before this fix, acceptOne() was losing FTP DATA TcpAcceptor context by unconditionally resetting the context to a nil listenPort_. Also, TcpAcceptor methods should not (be expected to) explicitly set their job code context. Instead, the job should be created in the right code context, allowing job-created async calls to auto-manage code context. The updated port-iterating clientHttpConnectionsOpen() and Ftp::StartListening() loops now set the right code context when creating async calls that result in TcpAcceptor job creation.
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Dec 28, 2022
Before this fix, acceptOne() was losing FTP DATA TcpAcceptor context by unconditionally resetting the context to a nil listenPort_. Also, TcpAcceptor methods should not (be expected to) explicitly set their job code context. Instead, the job should be created in the right code context, allowing job-created async calls to auto-manage code context. The updated port-iterating clientHttpConnectionsOpen() and Ftp::StartListening() loops now set the right code context when creating async calls that result in TcpAcceptor job creation.
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Jul 2, 2023
Before this fix, acceptOne() was losing FTP DATA TcpAcceptor context by unconditionally resetting the context to a nil listenPort_. Also, TcpAcceptor methods should not (be expected to) explicitly set their job code context. Instead, the job should be created in the right code context, allowing job-created async calls to auto-manage code context. The updated port-iterating clientHttpConnectionsOpen() and Ftp::StartListening() loops now set the right code context when creating async calls that result in TcpAcceptor job creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, acceptOne() was losing FTP DATA TcpAcceptor context
by unconditionally resetting the context to a nil listenPort_.
Also, TcpAcceptor methods should not (be expected to) explicitly set
their job code context. Instead, the job should be created in the
right code context, allowing job-created async calls to auto-manage code
context. The updated port-iterating clientHttpConnectionsOpen() and
Ftp::StartListening() loops now set the right code context when creating
async calls that result in TcpAcceptor job creation.