ext_time_quota_acl: convert to c++ (#1847)

Make use of dynamically-allocated strings
instead of static buffers, and convert debug output
to use Squid's Debug API

Inspired by addressing Coverity CID  1461163
"Invalid type in argument to printf format specifier"

doc/debug-sections.txt

@@ -130,6 +130,7 @@ section 80    WCCP Support
 section 81    Store HEAP Removal Policies
 section 81    aio_xxx() POSIX emulation on Windows
 section 82    External ACL
+section 82    External ACL Helpers
 section 83    SSL accelerator support
 section 83    SSL-Bump Server/Peer negotiation
 section 83    TLS I/O

src/Makefile.am

@@ -16,7 +16,8 @@ LOADABLE_MODULES_SOURCES = \
 	LoadableModules.cc \
 	LoadableModules.h
 
-SUBDIRS = mem time debug base anyp helper dns html ftp parser comm error eui acl format clients sbuf servers fs repl store DiskIO proxyp
+# subdir Y that requires a file built in subdir X must appear after X
+SUBDIRS = mem time debug base anyp helper dns html ftp parser comm error eui sbuf acl format clients servers fs repl store DiskIO proxyp
 
 if ENABLE_AUTH
 SUBDIRS += auth

src/acl/external/time_quota/Makefile.am

@@ -14,7 +14,15 @@ DEFS += -DDEFAULT_QUOTA_DB=\"$(localstatedir)/ext_time_quota.db\"
 
 ext_time_quota_acl_SOURCES = \
 	ext_time_quota_acl.cc
+
 ext_time_quota_acl_LDADD = \
+	$(top_builddir)/src/sbuf/libsbuf.la \
+	$(top_builddir)/src/debug/libdebug.la \
+	$(top_builddir)/src/error/liberror.la \
+	$(top_builddir)/src/comm/libminimal.la \
+	$(top_builddir)/src/mem/libminimal.la \
+	$(top_builddir)/src/base/libbase.la \
+	$(top_builddir)/src/time/libtime.la \
 	$(COMPAT_LIB) \
 	$(LIBTDB_LIBS)