Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proguard config for R8 to keep type information for generic signatures of retrofit2.Response #3910

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

ottne
Copy link
Contributor

@ottne ottne commented Jun 6, 2023

This rule is needed with R8 full mode for interfaces such as in the example below, as R8 strips generic signatures of Response.

Follow up of #3596.

interface WebApi {
    @GET("/api/data")
    fun getData(): Single<Response<MyData>>

    @GET("/api/data")
    suspend fun getDataSuspending(): Response<MyData>
}

@JakeWharton JakeWharton merged commit ef8d867 into square:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants