Add support for MultipartBody.Part in @Part #1467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a couple of interesting things I ran into with this change
|
| body = converter.convert(value); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unable to convert " + value + " to RequestBody", e); | ||
| if (MultipartBody.Part.class.isAssignableFrom(value.getClass())) { |
There was a problem hiding this comment.
This is known in the RequestFactoryParser and should have an action chosen for the type, not as just-in-time behavior.
|
There are many edge cases around this which are unknown and need evaluated before decided how to support this. |
|
I've updated the pull request. I'm not sure there's a clean way to do it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very much a work in progress. But it works for my needs. I'd like to push this functionality forward, but could use some direction. I'm happy to update the PR given any direction, or let someone else take over.
References #1140