Revert public API breaking change #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
reviewed
Jun 22, 2023
| @@ -800,7 +800,7 @@ public final class okio/Utf8 { | |||
| public static synthetic fun size$default (Ljava/lang/String;IIILjava/lang/Object;)J | |||
| } | |||
|
|
|||
| public final class okio/internal/-Utf8 { | |||
| public final class okio/internal/_Utf8Kt { | |||
There was a problem hiding this comment.
Don’t we need a - here?
There was a problem hiding this comment.
I think this is what it was doing before
There was a problem hiding this comment.
No, the API dump on 3.3.0 gives us
public final class okio/internal/_Utf8Kt {
public static final fun commonAsUtf8ToByteArray (Ljava/lang/String;)[B
public static final fun commonToUtf8String ([BII)Ljava/lang/String;
public static synthetic fun commonToUtf8String$default ([BIIILjava/lang/Object;)Ljava/lang/String;
}
swankjesse
approved these changes
Jun 22, 2023
oldergod
force-pushed
the
bquenaudon.2023-06-22.nonbreaking
branch
from
2df662f to
bfc39c6
Compare
oldergod
commented
Jun 22, 2023
| @@ -13,11 +14,8 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| @file:JvmName("-Utf8") // A leading '-' hides this class from Java. | |||
There was a problem hiding this comment.
Here's the api dump from 3.3.0
public final class okio/_JvmPlatformKt {
public static final fun withLock (Ljava/util/concurrent/locks/ReentrantLock;Lkotlin/jvm/functions/Function0;)Ljava/lang/Object;
}
swankjesse
approved these changes
Jun 22, 2023
swankjesse
pushed a commit
that referenced
this pull request
Jun 22, 2023
* Dump internal public APIs Since they're public... they might be used! * Revert public API breaking change (#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed happened here cd31c07#diff-aa9f6ad4ed05efc263a9cc5ab076514a3f851f6b0573d76580a99aa31fe5d21a
This introduced a API breaking change from out latest tag
3.3.0. Even though the package is internal, methods are public.