Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track new JavaPoet group and package name #2007

Closed
wants to merge 3 commits into from

Conversation

squarejesse
Copy link
Contributor

Rename the existing interop module to javapoet-deprecated and introduce a new module called javapoet that integrates with the Palantir JavaPoet fork.

  • docs/changelog.md has been updated if applicable.

Rename the existing interop module to javapoet-deprecated and
introduce a new module called javapoet that integrates with
the Palantir JavaPoet fork.
@squarejesse
Copy link
Contributor Author

The original integration is still around because I don’t want to break backwards compatibility. That’s especially important for projects like this one that might coexist on a Gradle build classpath with very old and very new code.

@JakeWharton
Copy link
Collaborator

The old implementation was never marked as stable, but at least the JavaPoet APIs behind it were stable. These new APIs are also not marked as stable, but the Palantir fork of JavaPoet is itself not stable either.

Do we even expect anyone to use this? The only project in the entire world using the old artifact is https://github.com/zlataovce/takenaka. I'm not sure I would bother until people start asking for this, which I'm not sure anyone ever would.

@squarejesse
Copy link
Contributor Author

I hadn’t even considered that this wasn’t used. Doubling up on dead code certainly feels like a waste.

I’ll close this. We can consider dropping the old integration completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants