Add support for IMAP STARTTLS #183
Conversation
|
|
|
Thank you! At first glance this looks reasonable, though I'm not very familiar with IMAP. Are there some servers "in the real world" that you know of which we can test this against? |
|
Sure, these servers support STARTTLS: imap.1and1.com |
| "net" | ||
| ) | ||
|
|
||
| func dumpAuthTLSFromIMAP(dialer Dialer, address string, config *tls.Config) (*tls.ConnectionState, error) { |
There was a problem hiding this comment.
Nit: the original naming here was probably taken from the FTP code, which sends an AUTH TLS message as part of the FTP STARTTLS protocol (explicit FTPS). Would probably make more sense if we called these something else now, like maybe dumpTLSConnStateFromFTP and dumpTLSConnStateFromIMAP.
|
Thank you for your contribution @seththeriault! I updated the method names and merged this into master. We'll try to cut a release with this soon. |
This is a quick-and-dirty attempt to add STARTTLS support for the IMAP protocol ( see #120 ) inspired by a recent blog post by @siebenmann. It definitely needs some review.