Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support constructor injection for classes with bounded type parameters #127

Merged
merged 2 commits into from
Sep 23, 2020
Merged

Support constructor injection for classes with bounded type parameters #127

merged 2 commits into from
Sep 23, 2020

Conversation

quiro91
Copy link
Contributor

@quiro91 quiro91 commented Sep 23, 2020

Fixes #126

vRallev
vRallev approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@vRallev vRallev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. I addressed smaller nits in a separate commit. Thanks for the contribution!

@vRallev vRallev merged commit 8fd9156 into square:main Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vRallev vRallev vRallev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support constructor injection for classes with bounded type parameters is unsupported
2 participants
@quiro91 @vRallev