Replace deps kr/pty with creak/pty to fix crash on macOs #134
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid in child' when using ssh and pty:true fix #110
|
I thank you for doing this, as I was about do to same 😅 and then i stumbled across this 🤔 Is Sampler no longer maintained? Seems like this has been open for a while now.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix for 'Setctty set but Ctty not valid in child' when using ssh and pty:true on macOS.
The issue was discussed here creack/pty#96; sampler was using an older fork kr/pty, the issue doesn't seem to be present with the latest creak/pty.
fix #110