This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
agent/rule/shellshock: fix splitting environment variables #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julio-Guerra
pushed a commit
that referenced
this pull request
Sep 22, 2020
New Feature: - (#152, #155) Add In-App WAF protection to Echo's request parameter parser: [`Context`](https://pkg.go.dev/github.com/labstack/echo/v4#Context)'s method `Bind()` is now protected by the In-App WAF. The Go value it parses from the HTTP request is made available to the In-App WAF rules via the `GET/POST parameters` field. When blocked, `Bind()` returns a non-nil [`SqreenError` value](https://godoc.org/github.com/sqreen/go-agent/sdk/types#SqreenError) and its caller should immediately return. Read more about the blocking behavior of Sqreen for Go at <https://docs.sqreen.com/go/integration>. Fix: - (#153) RASP shellshock: properly handle environment variables containing variable definitions (eg. `TERMCAP`).
Julio-Guerra
pushed a commit
that referenced
this pull request
Sep 22, 2020
New Feature: - (#152, #155) Add In-App WAF protection to Echo's request parameter parser: [`Context`](https://pkg.go.dev/github.com/labstack/echo/v4#Context)'s method `Bind()` is now protected by the In-App WAF. The Go value it parses from the HTTP request is made available to the In-App WAF rules via the `GET/POST parameters` field. When blocked, `Bind()` returns a non-nil [`SqreenError` value](https://godoc.org/github.com/sqreen/go-agent/sdk/types#SqreenError) and its caller should immediately return. Read more about the blocking behavior of Sqreen for Go at <https://docs.sqreen.com/go/integration>. Fix: - (#153) RASP shellshock: properly handle environment variables containing variable definitions (eg. `TERMCAP`).
Julio-Guerra
pushed a commit
to amnay-mo/go-agent
that referenced
this pull request
Sep 30, 2020
New Feature: - (sqreen#152, sqreen#155) Add In-App WAF protection to Echo's request parameter parser: [`Context`](https://pkg.go.dev/github.com/labstack/echo/v4#Context)'s method `Bind()` is now protected by the In-App WAF. The Go value it parses from the HTTP request is made available to the In-App WAF rules via the `GET/POST parameters` field. When blocked, `Bind()` returns a non-nil [`SqreenError` value](https://godoc.org/github.com/sqreen/go-agent/sdk/types#SqreenError) and its caller should immediately return. Read more about the blocking behavior of Sqreen for Go at <https://docs.sqreen.com/go/integration>. Fix: - (sqreen#153) RASP shellshock: properly handle environment variables containing variable definitions (eg. `TERMCAP`).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the environment variable lookup when other variable assignments are in the value.