This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
agent/rule/callback/waf: always recover panics #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general WAF is now recovering from panics if any to make sure the middlewares cannot panic at that point in case of a mistake. So far, only the function WAF was safe.
Merged
Julio-Guerra
pushed a commit
that referenced
this pull request
Sep 2, 2020
New Feature - (#142) RASP: add Shellshock protection support. This protection is currently attached to `os.StartProcess()` which is the common function of the Go standard library to execute a process. This protection can be configured at <https://my.sqreen.com/application/goto/modules/rasp/details/shellshock>. Fixes - (#145) In-App WAF: always recover from panics as this in the way the `reflect` package handles usage errors. - (#144) Backend client: avoid dropping HTTP traces in case of `Host` header parsing errors.
Julio-Guerra
pushed a commit
that referenced
this pull request
Sep 2, 2020
New Feature: - (#142) RASP: add Shellshock protection support. This protection is currently attached to `os.StartProcess()` which is the common function of the Go standard library to execute a process. This protection can be configured at <https://my.sqreen.com/application/goto/modules/rasp/details/shellshock>. Fixes: - (#145) In-App WAF: always recover from panics as this in the way the `reflect` package handles usage errors. - (#144) Backend client: avoid dropping HTTP traces in case of `Host` header parsing errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always recover from a panic if any. The use of the package
reflectmakes it indeed likelyto panic in case of a usage error. Only the function WAF - the WAF that is called when new
parameters are parsed - was recovering from panics.