-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown property does not work well with keyboard input #297
Comments
Hi and thank you very much for the detailed bug report ! Out of curiosity: what are you building with SQLPage ? I'll look into what can be done on our side, but it's possible a part of the behavior you are observing is coming from the upstream tomselect library. In this case take it'll take longer to fix. About your off-topic remark: where did you first hear about SQLPage ? Do you think there is something we could change on the SQLPage website or in the README to give it less of a DOOM on a toaster vibe ? |
Also, do you have a better name in mind to replace |
works around tabler/tabler#1879 fixes the first part of #297
@c-classen : can you try the latest fixes ? They'll be available on docker as |
I built a scoreboard application to keep track of the results of simraces we do in a small group. This way we can do multiplayer championships without the game directly supporting it. I mean a google spreadsheet would have probably done the job, but I really enjoyed learning SQLPage and it took just a few hours to get the whole thing working and deployed, which was about the same time it took me to figure out a solution to some weird babel nodejs issue I encountered with another framework I tried to set up. 🙃
Yes, that makes sense and the workaround you described works for me.
I searched for some easy way to create and deploy a whole web app, I think for frameworks utilizing isomorphic Javascript to be exact, and with some search terms I ended up either on the SQLPage website or the PostgreSQL news about it, I'm not sure anymore.
That is probably just me being narrow minded. The idea of using only SQL to create a complete web app just seemed kind of wild to me. 😄 If I had to give some suggestion, maybe switch out the "Beautiful" claim for a "Secure" claim on the landing page. On the one hand, I don't think beauty is something that makes this framework stand out from the others and it is probably not why people will pick SQLPage. Not that I want to criticize the styling, but people might think more about fancy animations and theming when hearing the term. On the other hand, the mere idea of defining frontend as well as backend in pure SQL screamed "SQL injection" at me, especially when concatenating URL query parameters into an SQL statement. Maybe you could link to this page to address concerns like these. But again, maybe my first impression was just due to my general skepticism.
Maybe something like
I did and...
The only room for improvement I still see would be having the filtering be applied instantly. There is still a little delay between typing something and the filtering being applied to the options dropdown. But the more noticeable issues are all resolved. Thank you for the quick fix and your great work with this project. |
I love this sentence ! Can I quote you on this on the website ?
Yes ! We often get questions about the security model, and it's really not evident how sqlpage handles it when reading the homepage. |
Sure, go ahead, you can also leave out the brackets around "a bug".
Yes, I probably underestimate the importance of looks as it is not something I focus on personally. |
I updated the homepage and added "searchable" as an alias of "dropdown". |
Introduction
I created a form which I mostly want to use with the keyboard (entering text, switching to the next component with tab, submitting the values with enter, etc.). However, the select component with the dropdown property set to true causes some issues:
To Reproduce
Actual behavior
Expected behavior
Version information
Additional context
I find the name "dropdown" for the property somewhat confusing. Even with the property missing or set to false, the input is still rendered as a dropdown. Only your ability to search it by entering text depends on the "dropdown" property. Also, there is a slight, but noticable delay between entering something and the dropdown filtering on the entries containing the entered phrase as a substring.
Off topic: Great project! When I first heard of it, I thought this would be more of an "installing DOOM on a toaster" kind of project. You know, where the question is more "Can it be done?" and less "Should it be done?" 😄 . But after creating a web app in less than 500 lines of code including database migrations, I must say this is awesome if you want a complete simple web app quickly.
The text was updated successfully, but these errors were encountered: