-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): Support subqueries in the FROM clause #3322
base: main
Are you sure you want to change the base?
Conversation
I've added a fix for unnamed subqueries. That panicked at HEAD and my branch, and works now :) |
@Jille, I think the reason why 7d1b0c6 was required is because this test uses an active database to perform type inference for the query. All tests that use the sqlc/internal/endtoend/endtoend_test.go Lines 121 to 144 in e8405b5
Here is where analysis is performed for columns that are not part of a table: sqlc/internal/engine/postgresql/analyzer/analyze.go Lines 272 to 288 in caaaacc
Notice that |
issue #2989, #2400 and probably others
This is without #3220 so we can separate which test failures are caused by which PR.