Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen/golang): Use int8 for MySQL TINYINT #3298

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(codegen/golang): Use int8 for MySQL TINYINT #3298

merged 1 commit into from
Mar 28, 2024

Conversation

kyleconroy
Copy link
Collaborator

Fixes #3201

@kyleconroy kyleconroy merged commit 2b5b7e0 into main Mar 28, 2024
6 of 8 checks passed
@kyleconroy kyleconroy deleted the kyle/tinyint-int8 branch March 28, 2024 18:09
@ariesdevil
Copy link

ariesdevil commented May 30, 2024 •
edited
Loading

What if sqlc.narg('A_TINYINT_COL')? cause golang sql package has no NullInt8, just a NullByte but byte is uint8.

lisitsky pushed a commit to lisitsky/sqlc that referenced this pull request Jun 21, 2024
@kyleconroy @lisitsky
fix(codegen/golang): Use int8 for MySQL TINYINT (sqlc-dev#3298)
1d7b117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL: Proper type for YEAR and TINYINT
2 participants
@kyleconroy @ariesdevil