-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mysql): :copyfrom support via LOAD DATA INFILE #2545
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
internal/codegen/golang/templates/go-sql-driver-mysql/copyfromCopy.tmpl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{{define "copyfromCodeGoSqlDriver"}} | ||
{{range .GoQueries}} | ||
{{if eq .Cmd ":copyfrom" }} | ||
var readerHandlerSequenceFor{{.MethodName}} uint32 = 1 | ||
|
||
func convertRowsFor{{.MethodName}}(w *io.PipeWriter, {{.Arg.SlicePair}}) { | ||
e := mysqltsv.NewEncoder(w, {{ len .Arg.Fields }}, nil) | ||
for _, row := range {{.Arg.Name}} { | ||
{{- with $arg := .Arg }} | ||
{{- range $arg.Fields}} | ||
{{- if eq .Type "string"}} | ||
e.AppendString({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- else if eq .Type "[]byte"}} | ||
e.AppendBytes({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- else}} | ||
e.AppendValue({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- end}} | ||
{{- end}} | ||
{{- end}} | ||
} | ||
w.CloseWithError(e.Close()) | ||
} | ||
|
||
{{range .Comments}}//{{.}} | ||
{{end -}} | ||
// {{.MethodName}} uses MySQL's LOAD DATA LOCAL INFILE and is not atomic. | ||
// | ||
// Errors and duplicate keys are treated as warnings and insertion will | ||
// continue, even without an error for some cases. Use this in a transaction | ||
// and use SHOW WARNINGS to check for any problems and roll back if you want to. | ||
// | ||
// Check the documentation for more information: | ||
// https://dev.mysql.com/doc/refman/8.0/en/load-data.html#load-data-error-handling | ||
func (q *Queries) {{.MethodName}}(ctx context.Context{{if $.EmitMethodsWithDBArgument}}, db DBTX{{end}}, {{.Arg.SlicePair}}) (int64, error) { | ||
pr, pw := io.Pipe() | ||
defer pr.Close() | ||
rh := fmt.Sprintf("{{.MethodName}}_%d", atomic.AddUint32(&readerHandlerSequenceFor{{.MethodName}}, 1)) | ||
mysql.RegisterReaderHandler(rh, func() io.Reader { return pr }) | ||
defer mysql.DeregisterReaderHandler(rh) | ||
go convertRowsFor{{.MethodName}}(pw, {{.Arg.Name}}) | ||
// The string interpolation is necessary because LOAD DATA INFILE requires | ||
// the file name to be given as a literal string. | ||
result, err := {{if (not $.EmitMethodsWithDBArgument)}}q.{{end}}db.ExecContext(ctx, fmt.Sprintf("LOAD DATA LOCAL INFILE '%s' INTO TABLE {{.TableIdentifierForMySQL}} %s ({{range $index, $name := .Arg.ColumnNames}}{{if gt $index 0}}, {{end}}{{$name}}{{end}})", "Reader::" + rh, mysqltsv.Escaping)) | ||
if err != nil { | ||
return 0, err | ||
} | ||
return result.RowsAffected() | ||
} | ||
|
||
{{end}} | ||
{{end}} | ||
{{end}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a gross hack, but I don't want to change how parseDriver works right now.