docs: Add release notes for v1.19.0 #2406
Conversation
kyleconroy
force-pushed
the
kyle/docs-1-19
branch
2 times, most recently
from
e0792fa
to
bc37e81
Compare
docs/reference/config.md
Outdated
|
|
||
| The `database` mapping supports the following keys: | ||
|
|
||
| - `url`: |
There was a problem hiding this comment.
I know this isn't the ideal time to offer naming suggestions, but we can't really change this after release so it's worth a brief discussion. uri is better than url in this context I think, if we want to indicate that we are only supporting the URI-style connection string format for various drivers (and not other formats e.g. key/value pairs).
I took a quick read of the postgres and mysql and sqlite docs on this and they all mention "URI."
If we want to be more flexible or generic we could use something like conn or conn_string or connection_string.
docs/howto/ci-cd.md
Outdated
| ``` | ||
|
|
||
| We also encourage running [`sqlc vet`](../reference/cli.html#vet). To get the most value out of `vet`, | ||
| you'll want to set up a running database. See the [vet] documentation for a |
There was a problem hiding this comment.
[vet] is missing a link url here, but would probably be redundant given the link in the previous sentence so probably just remove square brackets.
kyleconroy
force-pushed
the
kyle/docs-1-19
branch
from
33b77b7
to
2ae2847
Compare
No description provided.