Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken interaction between query_parameter_limit and pq.Array() #2383

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Fix broken interaction between query_parameter_limit and pq.Array() #2383

merged 4 commits into from
Jun 28, 2023

Commits on Jun 28, 2023

  1. Understand sqlc.slice() in more expression types 

    This was needed to understand PostgreSQL IN() which doens't surface as
an *ast.In
    @Jille
    Jille committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    479e19e View commit details
    Browse the repository at this point in the history

  2. Fix interaction between query_parameter_limit and sqlc.slice() 

    The sqlc.slice() templating code needed to understand how to refer to a variable when query_parameter_limit prevented struct emission.

issue sqlc-dev#2268
    @Jille
    Jille committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    da816bc View commit details
    Browse the repository at this point in the history

  3. Fix imports if a file has both sqlc.slice() and regular arrays 

    The pq import was missing in those cases. I ran into this while writing
a test case for sqlc-dev#2268 comment 2.
    @Jille
    Jille committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4c42ff8 View commit details
    Browse the repository at this point in the history

  4. Fix broken interaction between query_parameter_limit and pq.Array() 

    issue sqlc-dev#2268
    @Jille
    Jille committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2d98231 View commit details
    Browse the repository at this point in the history