New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MySQL slice shadowing database/sql import #2332

Merged

kyleconroy merged 2 commits into sqlc-dev:main from LudovicDebost:fix-mysql-slice

Jun 20, 2023

Contributor

LudovicDebost commented Jun 16, 2023 •

edited

Loading

The generated code use a var named sql but when the query return a database/sql type like sql.NullString then the var is shadowing the import.

Fixes #1816

LudovicDebost added 2 commits

June 16, 2023 12:06


          fix: MySQL slice with database/sql type

41d9eca


          fixed examples

551a16c

Collaborator

kyleconroy commented Jun 20, 2023

We'll have the same issue is someone uses a type in a query package, but that's not going to happen nearly as much as sql.

kyleconroy approved these changes

View reviewed changes

kyleconroy merged commit 3b21fdf into sqlc-dev:main

LudovicDebost deleted the fix-mysql-slice branch

June 21, 2023 06:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet