fix: Override types of aliased columns and named parameters #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haines
force-pushed
the
override-column-types
branch
from
09bf173
to
5a3e0c2
Compare
haines
force-pushed
the
override-column-types
branch
2 times, most recently
from
1d419ec
to
32556c0
Compare
haines
force-pushed
the
override-column-types
branch
from
32556c0
to
d6cbd2c
Compare
haines
force-pushed
the
override-column-types
branch
from
d6cbd2c
to
2ff3b63
Compare
6 tasks
haines
force-pushed
the
override-column-types
branch
from
2ff3b63
to
1004300
Compare
haines
force-pushed
the
override-column-types
branch
from
1004300
to
f3405f5
Compare
|
@haines Thanks for keeping this fresh! @kyleconroy We are using this patch and it is working well for us! |
haines
force-pushed
the
override-column-types
branch
from
f3405f5
to
7b3861e
Compare
|
@kyleconroy could you please take a look? |
haines
force-pushed
the
override-column-types
branch
from
7b3861e
to
0147036
Compare
haines
force-pushed
the
override-column-types
branch
from
0147036
to
effda1e
Compare
haines
force-pushed
the
override-column-types
branch
from
effda1e
to
67293b7
Compare
Signed-off-by: Andrew Haines <[email protected]>
haines
force-pushed
the
override-column-types
branch
from
67293b7
to
fe18361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
Fixes #1752
Fixes #1864
Column type overriding fails when columns are aliased or parameter names do not match the underlying column.
This PR makes the compiler preserve the original column name if a column is aliased in a query or if a named parameter is used instead of a numbered one, and uses that name (if present) to check for a matching type override in the config.