Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydantic models config field #1538

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Pydantic models config field #1538

merged 3 commits into from
Apr 20, 2022

Conversation

danicc097
Copy link
Contributor

Since dataclasses are the default since #939, I added an optional use_pydantic_models field to use Pydantic for all models (discussed since #923) which requires much less boilerplate later at least for my use case

kyleconroy
kyleconroy requested changes Apr 10, 2022
View reviewed changes
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first draft. Requested a few changes; let me know if you have any questions.

protos/plugin/codegen.proto Outdated Show resolved Hide resolved
examples/python/requirements.txt Outdated Show resolved Hide resolved
internal/plugin/codegen.pb.go Outdated Show resolved Hide resolved
examples/python/sqlc.json Outdated Show resolved Hide resolved
@kyleconroy kyleconroy merged commit 04c6c90 into sqlc-dev:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danicc097 @kyleconroy