fix tests

sqlc-dev · Oct 19, 2024 · f18de44 · f18de44
1 parent 8e385b4
commit f18de44
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/examples/booktest/mysql/db_test.go b/examples/booktest/mysql/db_test.go
@@ -5,6 +5,7 @@ package booktest
 import (
 	"context"
 	"database/sql"
+	"slices"
 	"testing"
 	"time"
 
@@ -155,7 +156,9 @@ func TestBooks(t *testing.T) {
 		Title: "my book title",
 		Yr:    2016,
 	})
-	for book := range rows.Iterate() {
+
+	// We need to collect the iterator elements to avoid panic when we make other db queries in the loop.
+	for _, book := range slices.Collect(rows.Iterate()) {
 		t.Logf("Book %d (%s): %s available: %s\n", book.BookID, book.BookType, book.Title, book.Available.Format(time.RFC822Z))
 		author, err := dq.GetAuthor(ctx, book.AuthorID)
 		if err != nil {

diff --git a/examples/booktest/postgresql/db_test.go b/examples/booktest/postgresql/db_test.go
@@ -4,6 +4,7 @@ package booktest
 
 import (
 	"context"
+	"slices"
 	"testing"
 	"time"
 
@@ -144,7 +145,9 @@ func TestBooks(t *testing.T) {
 		Title: "my book title",
 		Year:  2016,
 	})
-	for book := range rows.Iterate() {
+
+	// We need to collect the iterator elements to avoid panic when we make other db queries in the loop.
+	for _, book := range slices.Collect(rows.Iterate()) {
 		t.Logf("Book %d (%s): %s available: %s\n", book.BookID, book.BookType, book.Title, book.Available.Time.Format(time.RFC822Z))
 		author, err := dq.GetAuthor(ctx, book.AuthorID)
 		if err != nil {

diff --git a/examples/booktest/sqlite/db_test.go b/examples/booktest/sqlite/db_test.go
@@ -4,6 +4,7 @@ package booktest
 
 import (
 	"context"
+	"slices"
 	"testing"
 	"time"
 
@@ -143,7 +144,9 @@ func TestBooks(t *testing.T) {
 		Title: "my book title",
 		Yr:    2016,
 	})
-	for book := range rows.Iterate() {
+
+	// We need to collect the iterator elements to avoid panic when we make other db queries in the loop.
+	for _, book := range slices.Collect(rows.Iterate()) {
 		t.Logf("Book %d (%s): %s available: %s\n", book.BookID, book.BookType, book.Title, book.Available.Format(time.RFC822Z))
 		author, err := dq.GetAuthor(ctx, book.AuthorID)
 		if err != nil {