Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what autogenerate compares #1570

Closed
wants to merge 2 commits into from
Closed

Conversation

peterjc
Copy link
Contributor

@peterjc peterjc commented Nov 5, 2024

Description

I was struggling with empty upgrade/downgrade functions because both my database and my ORM were up to date. I wrongly assumed the comparison was against the previous database scheme as per the prior revision script(s).

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

I was struggling with empty upgrade/downgrade functions
because both my database and my ORM were up to date.
I wrongly assumed the comparison was against the previous
database scheme as per the prior revision script(s).
@peterjc
Copy link
Contributor Author

peterjc commented Nov 5, 2024

Cross reference #1086

@CaselIT CaselIT requested a review from zzzeek November 5, 2024 19:17
Copy link
Member

@zzzeek zzzeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the term "previous" and "latest" are confusing, since these terms are just being introduced here without much context

docs/build/autogenerate.rst Outdated Show resolved Hide resolved
docs/build/autogenerate.rst Outdated Show resolved Hide resolved
@peterjc
Copy link
Contributor Author

peterjc commented Nov 5, 2024

Your suggested terminology is clear to me too; updated.

@CaselIT CaselIT requested a review from zzzeek November 6, 2024 07:04
@zzzeek zzzeek requested a review from sqla-tester November 7, 2024 14:51
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision dec968b of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change dec968b: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588

@sqla-tester
Copy link
Collaborator

Federico Caselli (CaselIT) wrote:

not 100% correct, but I guess it's generally right

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588

@sqla-tester
Copy link
Collaborator

Michael Bayer (zzzeek) wrote:

agree close enough thanks for the review

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588 has been merged. Congratulations! :)

@peterjc peterjc deleted the patch-1 branch November 7, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants