-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify what autogenerate compares #1570
Conversation
I was struggling with empty upgrade/downgrade functions because both my database and my ORM were up to date. I wrongly assumed the comparison was against the previous database scheme as per the prior revision script(s).
Cross reference #1086 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the term "previous" and "latest" are confusing, since these terms are just being introduced here without much context
Your suggested terminology is clear to me too; updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision dec968b of this pull request into gerrit so we can run tests and reviews and stuff
New Gerrit review created for change dec968b: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588 |
Federico Caselli (CaselIT) wrote: not 100% correct, but I guess it's generally right View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588 |
Michael Bayer (zzzeek) wrote: agree close enough thanks for the review View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588 |
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5588 has been merged. Congratulations! :) |
Description
I was struggling with empty upgrade/downgrade functions because both my database and my ORM were up to date. I wrongly assumed the comparison was against the previous database scheme as per the prior revision script(s).
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>
in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>
in the commit messageHave a nice day!