Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license year to 2024 #1400

Closed
wants to merge 1 commit into from

Conversation

evilaliv3
Copy link
Contributor

No description provided.

@CaselIT
Copy link
Member

CaselIT commented Jan 19, 2024

thanks!

@zzzeek since sqlalchemy has now gained a script to manage the file headers and the dates should we copy it also to alembic? Or too much effort?

@zzzeek
Copy link
Member

zzzeek commented Jan 22, 2024

thanks!

@zzzeek since sqlalchemy has now gained a script to manage the file headers and the dates should we copy it also to alembic? Or too much effort?

probably. Typically I run a script here anyway, but it's not sustainable that we wait for PRs like this

@CaselIT
Copy link
Member

CaselIT commented Jan 22, 2024

I don't think updating the year is actually needed for the license to be value, but I'm not a layer so 🤷‍♂️

Let's accept this PR and maybe think if the script for the year makes sense also here

@CaselIT CaselIT requested a review from sqla-tester January 22, 2024 19:16
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 477619c of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 477619c: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5116

@sqla-tester
Copy link
Collaborator

Michael Bayer (zzzeek) wrote:

thank you!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5116

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5116 has been merged. Congratulations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants