-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify ops to have kw only set up (e.g. add the '*') #1130
Labels
Milestone
Comments
Mike Bayer has proposed a fix for this issue in the main branch: wip: keyword only arguments in ops https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4238 |
sqlalchemy-bot
pushed a commit
that referenced
this issue
Nov 26, 2022
command is: find alembic -name "*.py" | xargs pyupgrade --py37-plus --keep-runtime-typing --keep-percent-format I'm having some weird fighting with the tools/write_pyi, where in different runtime contexts it keeps losing "MigrationContext" and also Callable drops the args, but it's not consisistent. For whatever reason, under py311 things *do* work every time. im working w/ clean tox environments so not really sure what the change is. anyway, let's at least fix the quoting up around the types. This is towards getting the "*" in the op signatures for #1130. Change-Id: I9175905d3b4325e03a97d6752356b70be20e9fad
not ready to do this for now, want to get 1.9 out with the new alembic check feature |
Mike Bayer has proposed a fix for this issue in the main branch: add a few more kw only https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4614 |
sbrunner
added a commit
to camptocamp/c2cgeoportal
that referenced
this issue
Jun 7, 2023
sbrunner
added a commit
to camptocamp/c2cgeoportal
that referenced
this issue
Jun 7, 2023
sbrunner
added a commit
to camptocamp/c2cgeoportal
that referenced
this issue
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
we likely have to modify
tools/write_pyi
to handle this, autogenerate is likely OK and the change here is probably warranting of a bigger release bump. But we should guard against issues like #1127 and we should have done this when we released for Python 3.The text was updated successfully, but these errors were encountered: