PR: Remove support for PyQt4 #6961
Conversation
Also bump PyQt5 requirement to 5.5
Also: - Add a new env var called USE_CONDA to clearly state what slots use conda and what use pip. - Add a new slot to test with Python 3.5 and conda.
|
Hello @ccordoba12! Thanks for updating the PR.
Comment last updated on May 21, 2018 at 21:04 Hours UTC |
There was a problem hiding this comment.
Can we instead make the doc changes against the spyder-docs repo instead, since that's where they live now and will be backported to the main Spyder repo with each release? I'd be happy to make then myself right now if you'd like; I'm working a PR with a number of baseline updates and fixes like this for them of this nature. Otherwise, considering the changes already present there and that will be present shortly, that will be pulled back in to the main repo on the next release, it'll certainly be a lot of conflicts to resolve and in any case, I was under the impression that would be our "live" docs branch from now on, with this one just being included for now to maintain backward compatibility.
If that's not what you want us to do and we want to have a different system instead, then we can go ahead with that but please let me know so we're on the same page. Thanks!
bootstrap.py
Outdated
| except ImportError: | ||
| print("02. No PyQt5 or PyQt4 detected, using PySide if available " | ||
| "(deprecated)") | ||
| print("02. No PyQt5 detected (deprecated)") |
There was a problem hiding this comment.
What does (deprecated) refer to here? Before it referred to the deprecated pyside support but that was deleted, so since PyQt5 is (hopefully) not deprecated also we can presumably delete that parenthetical?
There was a problem hiding this comment.
Sorry, I have to remove that deprecated.
| * `PyQt5 <https://www.riverbankcomputing.com/software/pyqt/download5>`_ >=5.2 or | ||
| `PyQt4 <https://www.riverbankcomputing.com/software/pyqt/download>`_ >=4.6.0 | ||
| (PyQt5 is recommended). | ||
| * `PyQt5 <https://www.riverbankcomputing.com/software/pyqt/download5>`_ >=5.5 |
There was a problem hiding this comment.
Doc changes; see top level comment.
There was a problem hiding this comment.
@ccordoba12 Just FYI, if you don't get to it before I do my pass for baseline correctness updates (which will happen as soon as we resolve spyder-ide/spyder-docs#14 ) I can just do it as one part of that, as it is a close fit for the purpose and scope of the issue its resolving.
| Spyder may also be used as a PyQt5 or PyQt4 extension library | ||
| (module 'spyder'). For example, the Python interactive shell widget | ||
| used in Spyder may be embedded in your own PyQt5 or PyQt4 application. | ||
| Spyder may also be used as a PyQt5 extension library (module |
setup.py
Outdated
| It also provides ready-to-use pure-Python widgets to your PyQt5 or | ||
| PyQt4 application: source code editor with syntax highlighting and | ||
| It also provides ready-to-use pure-Python widgets to your PyQt5 | ||
| application: source code editor with syntax highlighting and |
There was a problem hiding this comment.
Should be "A source code editor"
|
@ccordoba12 Left a comment with a few minor issues, mainly about the doc changes potentially going to the wrong repo. |
|
Ok, I'll address your comments and also open a new PR in spyder-docs. After this PR I'll make no further changes to our docs here. I'm also thinking that, since we bumped our version to 3.3, we can remove our docs from here, stop distributing them in our tarballs and instead display them only online, i.e. through our website. |
|
@ccordoba12 Okay, sure—whatever you think is best. Would you like me to open a PR to do that, or will you handle it? Presumably, along with deleting the files we'll also need to remove the relevant section in |
Let me do it. I know all the things that have to be removed. |
|
@ccordoba12 As part of this PR, would you also want to consider updating the minimum Qt/PyQt version to 5.6? In the thousands of bug reports from the past year, I don't know if I've seen a single user using 5.5, it is long unsupported not being a LTS like 5.6, it isn't compatible with the high dpi scaling Spyder uses, we don't test with it, and in some of these places the min Qt/PyQt version listed is even older, e.g. 5.2. There's also some other old code still around for compatibility with Qt <5.5 that this PR doesn't catch, like in |
It'd be more work for little gain. I think 5.5 is fine. |
ccordoba12
dismissed
CAM-Gerlach’s stale review
Address review and open a PR in spyder-docs to remove mentions to PyQt4
Fixes #6889.