-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Split Projects module #5214
PR: Split Projects module #5214
Conversation
Hello @rlaverde! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 23, 2017 at 17:23 Hours UTC |
Well they are not really widgets, so maybe at the same level as the widgets folder? or with the api? |
I think that at the same level of the widget folder. (as in outlineexplorer) Also the |
Yeah, not sure how this goes, but the base project needs to be extendable by other type of projects |
What about |
Maybe languages? although we will need a more general word @goanpeca do you remember the word that we think that could work for the api? |
@rlaverde, please rebase and finish this one. |
I'll use |
098b7a0
to
4955461
Compare
Done |
This looks good to me. I just have a minor suggestion: renaming Then I'll merge. |
4955461
to
85cb812
Compare
Done |
I'm not sure where is the best place to put, I put it in the root and move itstype
folder__init__.py
toapy.py