Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Split Projects module #5214

Merged
merged 15 commits into from
Sep 23, 2017
Merged

Conversation

rlaverde
Copy link
Member

@rlaverde rlaverde commented Sep 12, 2017

projects/
├── api.py
├── confpage.py
├── __init__.py
├── plugin.py
├── projectstypes
│   ├── __init__.py
│   └── python.py
├── utils
│   ├── config.py
│   └── __init__.py
└── widgets
    ├── explorer.py
    ├── __init__.py
    ├── projectdialog.py
    └── tests
        ├── __init__.py
        ├── test_configdialog.py
        ├── test_projectdialog.py
        └── test_project_explorer.py

I'm not sure where is the best place to put type folder, I put it in the root and move its __init__.py to apy.py

@rlaverde rlaverde added this to the v4.0beta2 milestone Sep 12, 2017
@rlaverde rlaverde self-assigned this Sep 12, 2017
@pep8speaks
Copy link

pep8speaks commented Sep 12, 2017

Hello @rlaverde! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 23, 2017 at 17:23 Hours UTC

@goanpeca
Copy link
Member

I'm not sure where is the best place to put type folder

Well they are not really widgets, so maybe at the same level as the widgets folder? or with the api?

@rlaverde
Copy link
Member Author

Well they are not really widgets, so maybe at the same level as the widgets folder? or with the api?

I think that at the same level of the widget folder. (as in outlineexplorer)

Also the types/__init__ contains the EmptyProject I think that should be part of the api

@goanpeca
Copy link
Member

Also the types/init contains the EmptyProject I think that should be part of the api

Yeah, not sure how this goes, but the base project needs to be extendable by other type of projects

@ccordoba12
Copy link
Member

type is a Python keyword, so we shouldn't use it as a module name.

What about projectstype or projtypes?

@rlaverde
Copy link
Member Author

Maybe languages? although we will need a more general word

@goanpeca do you remember the word that we think that could work for the api?

@ccordoba12
Copy link
Member

@rlaverde, please rebase and finish this one.

@rlaverde
Copy link
Member Author

rlaverde commented Sep 19, 2017

I'll use projectstypes. Although we need yo unify these names, In OutlineExplorer a file with a similar function is called languages.py

@rlaverde
Copy link
Member Author

please rebase and finish this one.

Done

@ccordoba12
Copy link
Member

ccordoba12 commented Sep 20, 2017

This looks good to me. I just have a minor suggestion: renaming projectstypes to projecttypes (two plural words in English is rarely used).

Then I'll merge.

@rlaverde
Copy link
Member Author

I just have a minor suggestion: renaming projectstypes to projecttypes

Done

@ccordoba12 ccordoba12 merged commit 7ae9719 into spyder-ide:split-plugins Sep 23, 2017
@rlaverde rlaverde deleted the split-projects branch September 23, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants