-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Split History module #4593
PR: Split History module #4593
Conversation
rlaverde
commented
Jun 12, 2017
- Move history to a module
- Also decouple the plugin UI in a widget to make it reusable and easy testable.
@rlaverde please fix docstrings. They should end in a period and use a single line if they fit. Always triple quotes """Something something something.""" or """
Something something something.
Extra something.
""" |
@rlaverde this PR doesn't contain any renames, so git won't be able to detect the right file when we want to merge changes from 3.x. So I think you need to redo this PR and use renames instead. |
By renames, I mean |
Ok, we need to be careful with changes to this plugin then. |
spyder/plugins/history/widgets.py
Outdated
from spyder.widgets.sourcecode import codeeditor | ||
from spyder.config.base import _ | ||
from spyder.utils import icon_manager as ima | ||
from spyder.utils.qthelpers import (add_actions, create_toolbutton) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parenthesis are not needed here.
I left a minor comment, then I'll merge. |