-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Restore widget shortcuts to Preferences and allow to change them on the fly (Shortcuts) #23024
base: master
Are you sure you want to change the base?
Commits on Nov 23, 2024
-
API: Improve docstrings of SpyderShortcutsMixin
The current docstrings were not easy to understand.
Configuration menu - View commit details
-
Copy full SHA for bcbf1e2 - Browse repository at this point
Copy the full SHA bcbf1e2View commit details -
Shortcuts: Use a dataclass to represent shortcut data
- The previous solution, which used tuples to collect those data, was easy to break, because it required to put data in the right order; and undocumented, because it was unclear what kind of data had to be added in the tuple elements. - Those limitations made difficult to reason about shortcuts-related code.
Configuration menu - View commit details
-
Copy full SHA for 474c185 - Browse repository at this point
Copy the full SHA 474c185View commit details -
Configuration menu - View commit details
-
Copy full SHA for 029dfdd - Browse repository at this point
Copy the full SHA 029dfddView commit details -
API: Allow to add callables to observe an option in our config system
- Before we only allowed class methods decorated with on_conf_change to do that. - But that's too limited if we need to use regular functions to observe an option. And that's precisely what this new method allows us to do.
Configuration menu - View commit details
-
Copy full SHA for 38b3211 - Browse repository at this point
Copy the full SHA 38b3211View commit details -
Config: Notify when a shortcut is changed in our config system
This is necessary to add observers for specific shortcuts.
Configuration menu - View commit details
-
Copy full SHA for b41b593 - Browse repository at this point
Copy the full SHA b41b593View commit details -
API: Add an observer for each shortcut registered for a widget
- That allows those shortcuts to be updated on the fly when they are changed in Preferences or directly with set_conf. - Also, fix inheritance of classes that inherit from SpyderShortcutsMixin to accomodate this change.
Configuration menu - View commit details
-
Copy full SHA for 235587e - Browse repository at this point
Copy the full SHA 235587eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9f5374 - Browse repository at this point
Copy the full SHA d9f5374View commit details -
Testing: Remove setting CONF_SECTION for EditorStack/EditorSplitter
That was introducing an error in test_shortcut_for_widget_is_updated when run on CI due to the incorrectly named section.
Configuration menu - View commit details
-
Copy full SHA for a924b4a - Browse repository at this point
Copy the full SHA a924b4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70cd666 - Browse repository at this point
Copy the full SHA 70cd666View commit details -
API: Add plugin_name kwarg to register_shortcut_for_widget
This is to have feature parity of kwargs with the other methods of SpyderShortcutsMixin.
Configuration menu - View commit details
-
Copy full SHA for 8257479 - Browse repository at this point
Copy the full SHA 8257479View commit details
Commits on Nov 24, 2024
-
Shortcuts: Move SHORTCUTS_FOR_WIDGETS_DATA to its plugin and make it …
…public That's because it's going to be used in other places, so it's not good to leave it as private in our API.
Configuration menu - View commit details
-
Copy full SHA for 1f336d9 - Browse repository at this point
Copy the full SHA 1f336d9View commit details