PR: Add a widget to show connection logs to ConnectionDialog (Remote client)
#22328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were simply using black and white for the foreground/background colors of several syntax highlighting light themes, which didn't blend the editor as expected with the rest of the app. - Also, match the foreground color of the Spyder dark theme with the palette one because we need to use it in other places.
Also, make some small style improvements.
Previous fixes for padding only worked on Linux.
Also, remove some repeated imports.
Also, add tooltip when validating pages to empty fields.
That's because users will probably want to interact with servers through the dialog rather than create new connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Besides that, I also fixed other minor issues that were required to provide a good UI for this:
Visual changes
Before
After
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12