Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display py.test results as they come in #91

Merged
merged 35 commits into from
Dec 18, 2017

Conversation

jitseniesen
Copy link
Member

@jitseniesen jitseniesen commented Dec 13, 2017

The goal of this pull request is to give the user continuous feedback on the test run, instead of waiting till the end before displaying any results. I find it curiously satisfying to see the count of successful test go up and up. 😉 This required a change in the design: instead of parsing the JUnitXml (which is generated after the test run), the plugin now interacts with py.test's API.

This turned out to be more work than I expected, but it is almost done now. Hopefully the new design will pay back in the future.

To do:

  • Check Python 2 compatibility
  • Eliminate py.test warnings in tests
  • Eliminate code duplication in RunnerBase.start() and PytestRunner.start()
  • Move JUnitXml parsing from RunnerBase to NoseRunner

Fixes #13
Fixes #50

This will allow us to define hooks to report status while the test suite
is being run.
Necessary because Python does not flush stdout automatically if run
non-interactively.
This functionality was lost in the model/view split.
@jitseniesen jitseniesen added this to the v0.3 milestone Dec 13, 2017
@jitseniesen jitseniesen self-assigned this Dec 13, 2017
@jitseniesen
Copy link
Member Author

After:
realtime-after

Before:
realtime-before

@goanpeca
Copy link
Member

goanpeca commented Dec 13, 2017

This is very nice work @jitseniesen, I like it :-).

@goanpeca
Copy link
Member

@jitseniesen maybe we should change the name from Kill to Stop ?

@ccordoba12
Copy link
Member

Great addition @jitseniesen!

@jitseniesen
Copy link
Member Author

@jitseniesen maybe we should change the name from Kill to Stop ?

Good idea --> #92

@jitseniesen jitseniesen merged commit 8d4422f into spyder-ide:master Dec 18, 2017
@jitseniesen jitseniesen deleted the realtime branch December 18, 2017 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants