PR: Use target env instead of Spyder env when checking dependencies #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to seperate code for the Spyder environment from code for the target environment. Next I will put them in different directories.
Put all code to be run in the target environment in a separate directory called workers. This should aid maintainability, but it also removes the requirement to have Qt installed in the target environment.
When displaying the dependencies of the plugin, which lists which testing frameworks are installed and their versions, use the target environment instead of the Spyder environment to retrieve the dependencies.
The plugin configuration dialog window greys out testing frameworks which are not available. This commit uses the target environment instead of the Spyder environment when detecting which frameworks are available.
These are no longer used after the previous commits.
Store dependency information in a cache when it is retrieved. Use the cached information when displaying the plugin configuration dialog, unless user changed the target environment (because the dependency information depends on the target environment).
If coverage is unavailable, then uncheck the checkbox (it is already disabled in the current code), so that if the user changes the target environment and the new environment does not have pytest_cov then the user does not get a disabled checkbox with no possibility of unchecking it.
Codecov Report
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking dependencies (pytest, nose, and their plugins), either for the Dependencies information dialog or for the plugin configuration dialog, use the target environment instead of the Spyder environment. As a nice side-effect, the user no longer needs to install Qt in the target environment when using the pytest framework; the only dependencies in the target environment now are pytest itself and zeromq (the latter is also a dependency of spyder-kernels so likely to be installed).
Fixes #177