Fix pytest test filename path resolution #149
Conversation
|
I just saw that the checks failed due to an internal server error: can you re-run them or shall I push a dummy commit to trigger the re-run (see How do I re-run Github Actions)? |
|
I tried re-running them but there is something wrong with Actions according to the GitHub status page. I'll try again tomorrow. |
|
The tests now work and pass. In the future, feel free to push empty commits. Regarding toe code, it's a small patch which I like. My first thought was to compute the rootdir ourselves, but it is more robust to get it from pytest as you are doing. It will probably be a few days before I can look at it in detail. |
Pytest test filenames are relative to the rootdir. This rootdir is not necessarily the directory from which discovery starts, i.e. wdir from spyder-unittest's config. For details on how pytest determins the rootdir see https://docs.pytest.org/en/latest/customize.html#initialization-determining-rootdir-and-inifile. Filenames used to be resolved against wdir. If wdir is not the rootdir (as described in the above link) this resulted in invalid resolved filenames. This commit gets the rootdir in the pytest_report_header hook which is called after all configuration is done and before any test collection starts. This rootdir is then used for filename path resolution.
Codecov Report
|
|
I rebased this PR onto the current master so that it again is mergeable now. |
|
Thanks! |
Pytest test filenames are relative to the
rootdir. Thisrootdiris notnecessarily the directory from which discovery starts, i.e.
wdirfromspyder-unittest's
config. For details on how pytest determins therootdirseeInitialization: determining rootdir and inifile
Filenames used to be resolved against
wdir. Ifwdiris not therootdir(asdescribed in the above link) this resulted in invalid resolved filenames.
This commit gets the
rootdirin thepytest_report_headerhook which iscalled after all configuration is done and before any test collection
starts. This
rootdiris then used for filename path resolution.This resolves #145