Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR : Spyder 6 compatibility #349

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Conversation

Zybulon
Copy link

@Zybulon Zybulon commented Sep 7, 2024

Hello,

I have updated the code to be compatible with Spyder 6.

@Zybulon Zybulon marked this pull request as draft September 7, 2024 14:48
@Zybulon Zybulon marked this pull request as ready for review September 7, 2024 14:51
@Zybulon Zybulon marked this pull request as draft September 7, 2024 14:54
@Zybulon Zybulon marked this pull request as ready for review September 7, 2024 15:19
@Zybulon Zybulon marked this pull request as draft September 7, 2024 15:20
@Zybulon Zybulon marked this pull request as ready for review September 7, 2024 15:26
@Zybulon Zybulon mentioned this pull request Sep 21, 2024
@Zybulon
Copy link
Author

Zybulon commented Sep 21, 2024

The tests do not pass. They failed not because of the corrections I made but because of the dependencies are too old.
Honestly I don't think I would have time to make the tests pass. So I think I'll stop here, unless someone update the tests.

@Zybulon Zybulon marked this pull request as ready for review September 22, 2024 06:08
@Zybulon
Copy link
Author

Zybulon commented Sep 22, 2024

All the test are ok except for one. The test behaviour is not reproductible, if you run it enough time it will eventually pass. I would say that it is not a real issue but the tests needs to be improved.

@Zybulon Zybulon changed the title Spyder 6 compatibility PR : Spyder 6 compatibility Sep 28, 2024
@Zybulon
Copy link
Author

Zybulon commented Sep 28, 2024

@steff456 could you review the PR so that it can be merged with the main branch ?

@ccordoba12
Copy link
Member

@Zybulon, thanks a lot for your work on this! We'll take a look at it to release a new version as soon as we can (probably in two or three weeks).

@bnavigator
Copy link
Contributor

Any news here?

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Nov 20, 2024
https://build.opensuse.org/request/show/1224495
by user bnavigator + anag+factory
Not maintained upstream. (Attempt stalled: spyder-ide/spyder-terminal#349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants