PR: Resolve possible macOS application bundle symlink #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If pyexec is not a symlink, nothing will change. If pyexec is a symlink and in a conda environment, then the symlink will resolve to pythonX.XX in the same directory, so the result of get_conda_env_path will be the same. If pyexec is a symlink that is neither in a conda environment nor in a macOS application bundle, then the result get_conda_env_path may be different, but it wasn't a conda environment anyway.
ccordoba12
changed the title
|
Closing as unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pyexec is not a symlink, nothing will change. If pyexec is a symlink and in a conda environment, then the symlink will resolve to pythonX.XX in the same directory, so the result of get_conda_env_path will be the same. If pyexec is a symlink that is neither in a conda environment nor in a macOS application bundle, then the result get_conda_env_path may be different, but it wasn't a conda environment anyway.